Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add role-based access control for bridge #1350

Merged
merged 51 commits into from
May 7, 2024
Merged

feat: add role-based access control for bridge #1350

merged 51 commits into from
May 7, 2024

Conversation

tkxkd0159
Copy link
Member

@tkxkd0159 tkxkd0159 commented May 2, 2024 •
edited
Loading

Description

closes: #XXXX

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@tkxkd0159 tkxkd0159 added the A: feature New features label May 2, 2024
@tkxkd0159 tkxkd0159 self-assigned this May 2, 2024
@codecov Codecov
Copy link

codecov bot commented May 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 32.07856% with 415 lines in your changes are missing coverage. Please review.

Project coverage is 69.52%. Comparing base (956d7a6) to head (3e332f7).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##            pjdp1    #1350      +/-   ##
==========================================
- Coverage   69.98%   69.52%   -0.46%     
==========================================
  Files         663      672       +9     
  Lines       55440    56107     +667     
==========================================
+ Hits        38800    39011     +211     
- Misses      14407    14833     +426     
- Partials     2233     2263      +30
Files Coverage Δ
simapp/app.go 80.06% <100.00%> (ø)
x/fbridge/types/codec.go 54.54% <50.00%> (ø)
x/fbridge/keeper/params.go 83.33% <83.33%> (ø)
x/fbridge/types/msgs.go 0.00% <0.00%> (ø)
x/fbridge/types/fbridge.go 0.00% <0.00%> (ø)
x/fbridge/types/params.go 42.42% <42.42%> (ø)
x/fbridge/keeper/keeper.go 67.85% <70.00%> (+17.85%) ⬆️
x/fbridge/types/keys.go 0.00% <0.00%> (ø)
x/fbridge/keeper/abci.go 0.00% <0.00%> (ø)
x/fbridge/keeper/genesis.go 10.34% <8.33%> (+10.34%) ⬆️
... and 4 more

... and 1 file with indirect coverage changes

0Tech
0Tech reviewed May 3, 2024
View reviewed changes
x/fbridge/keeper/auth.go Outdated Show resolved Hide resolved
x/fbridge/keeper/genesis.go Outdated Show resolved Hide resolved
x/fbridge/keeper/grpc_query.go Outdated Show resolved Hide resolved
x/fbridge/module/abci.go Outdated Show resolved Hide resolved
0Tech
0Tech reviewed May 3, 2024
View reviewed changes
x/fbridge/keeper/auth.go Outdated Show resolved Hide resolved
0Tech
0Tech reviewed May 3, 2024
View reviewed changes
proto/lbm/fbridge/v1/query.proto Show resolved Hide resolved
x/fbridge/keeper/genesis.go Show resolved Hide resolved
x/fbridge/keeper/auth.go Show resolved Hide resolved
x/fbridge/types/genesis.go Show resolved Hide resolved
x/fbridge/types/genesis.go Outdated Show resolved Hide resolved
@tkxkd0159 tkxkd0159 requested a review from 0Tech May 7, 2024 07:31
@Finschia Finschia deleted a comment from 0Tech May 7, 2024
zemyblue
zemyblue reviewed May 7, 2024
View reviewed changes
Copy link
Member

@zemyblue zemyblue left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about changing the panic message of unimplemented tx?

func (m msgServer) ClaimBatch(ctx context.Context, msg *types.MsgClaimBatch) (*types.MsgClaimBatchResponse, error) {
	panic("implement me")
}

How about Not supported or Not implemented? :)

Because this message will displayed as error when request this tx.

@tkxkd0159 tkxkd0159 requested a review from zemyblue May 7, 2024 08:11
0Tech
0Tech previously approved these changes May 7, 2024
View reviewed changes
x/fbridge/keeper/keeper.go Outdated Show resolved Hide resolved
@tkxkd0159 tkxkd0159 requested review from 0Tech and zemyblue May 7, 2024 09:09
@tkxkd0159 tkxkd0159 requested a review from jaeseung-bae May 7, 2024 10:00
@tkxkd0159 tkxkd0159 merged commit 28f5fa3 into pjdp1 May 7, 2024
32 of 33 checks passed
@tkxkd0159 tkxkd0159 deleted the bridge-ac branch May 7, 2024 11:49
@tkxkd0159 tkxkd0159 mentioned this pull request May 7, 2024
Merged
5 tasks
@mergify mergify bot mentioned this pull request May 7, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeseung-bae jaeseung-bae jaeseung-bae approved these changes

@0Tech 0Tech 0Tech approved these changes

@zemyblue zemyblue zemyblue approved these changes

Assignees

@tkxkd0159 tkxkd0159

Labels
A: feature New features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tkxkd0159 @zemyblue @0Tech @jaeseung-bae